Books page integration #6323
Merged
Books page integration #6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show + to denote expandable sections - visual accents on omnibar - adjust editions table padding - move some options below table (better packing)
- Nest table within `.tab-section` - Remove horizontal rule above table - Move "View all editions" prompt above table - Use proper singular form in editions count message
mekarpeles
commented
Mar 21, 2022
jimchamp
reviewed
Mar 22, 2022
|
Committed change to the first publish year:
|
jimchamp
reviewed
Mar 23, 2022
This was referenced Mar 23, 2022
cdrini
reviewed
Mar 24, 2022
There was a problem hiding this comment.
Tested:
- normal work: https://testing.openlibrary.org/works/OL16612125W/Journeys_of_women_in_science_and_engineering
- readable work: https://testing.openlibrary.org/works/OL7000994W/The_little_corner_never_conquered
- Non available work: https://testing.openlibrary.org/works/OL21703472W/Discover_and_Do
- Book url https://testing.openlibrary.org/books/OL33811847M/Discover_and_Do
Bugs for future PRs:
- omnibar sits overtop profile menu
- want to read button sits above profile menu on tablet mode
Code has been reviewed/approved by @mekarpeles and @jimchamp ; please feel free to merge and deploy!
|
(Letting you merge @jimchamp , outside our normal flow, since @mekarpeles is the assignee/reviewer and currently away; I just did some light testing :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup re: #6277
Testing
on http://ol-dev1.us.archive.org:1337/
Stakeholders
@cdrini @seabelis @mekarpeles @jimchamp @mheiman @bfalling